Implements RolloverAction with new interface, fixes default action retry commit #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert Downs <[email protected]>
…etry Signed-off-by: Clay Downs <[email protected]>
Signed-off-by: Robert Downs <[email protected]>
Codecov Report
@@ Coverage Diff @@
## development-extension #231 +/- ##
===========================================================
+ Coverage 60.57% 63.25% +2.67%
- Complexity 1346 1438 +92
===========================================================
Files 249 249
Lines 9464 9647 +183
Branches 1447 1494 +47
===========================================================
+ Hits 5733 6102 +369
+ Misses 3046 2796 -250
- Partials 685 749 +64
Continue to review full report at Codecov.
|
Signed-off-by: Robert Downs <[email protected]>
thalurur
reviewed
Dec 20, 2021
src/main/kotlin/org/opensearch/indexmanagement/indexstatemanagement/action/RolloverAction.kt
Outdated
Show resolved
Hide resolved
thalurur
reviewed
Dec 20, 2021
src/test/kotlin/org/opensearch/indexmanagement/indexstatemanagement/model/XContentTests.kt
Outdated
Show resolved
Hide resolved
thalurur
previously approved these changes
Dec 20, 2021
Signed-off-by: Clay Downs <[email protected]>
thalurur
approved these changes
Dec 20, 2021
annie3431
reviewed
Dec 21, 2021
| @@ -67,4 +67,8 @@ abstract class Action( | |||
| final fun isLastStep(stepName: String): Boolean = getSteps().last().name == stepName | |||
|
|
|||
| final fun isFirstStep(stepName: String): Boolean = getSteps().first().name == stepName | |||
|
|
|||
| companion object { | |||
| const val DEFAULT_RETRIES = 3L | |||
There was a problem hiding this comment.
Just out of curiosity, what does 3L stand for?
There was a problem hiding this comment.
The L suffix there designates that the number is a long, so it would be equivalent to do const val DEFAULT_RETRIES: Long = 3. There are similar suffixes such as d for double or f for float, and they just let you designate a type when writing out a numeric literal.
annie3431
approved these changes
Dec 21, 2021
downsrob
pushed a commit
to downsrob/index-management
that referenced
this pull request
Mar 8, 2022
Signed-off-by: Ravi Thaluru <[email protected]> Base commit to clean up old action interfaces and disabling all ISM related tests (opensearch-project#218) Signed-off-by: Ravi Thaluru <[email protected]> Implement DeleteAcion using new interface (opensearch-project#221) Signed-off-by: Ravi Thaluru <[email protected]> Adding base logic to transition step to enable policy execution (opensearch-project#223) Signed-off-by: Ravi Thaluru <[email protected]> Support close action using new interface (opensearch-project#224) * Implement close action Signed-off-by: Annie Lee <[email protected]> * Update functions Signed-off-by: Annie Lee <[email protected]> * Update AttemptCloseStepTests.kt Signed-off-by: Annie Lee <[email protected]> * Mark a test as private for now Since TransitionAction is not yet implemented. Marking a test as private to avoid integ test failure Signed-off-by: Annie Lee <[email protected]> * Update CloseActionIT.kt Signed-off-by: Annie Lee <[email protected]> Implement ReadOnlyAction using new interface (opensearch-project#227) * Refactors ReadOnlyAction Signed-off-by: Robert Downs <[email protected]> Implement ReadWriteAction using new interface (opensearch-project#228) Signed-off-by: Clay Downs <[email protected]> Implement OpenAction using new interface (opensearch-project#230) * Support open action Signed-off-by: Annie Lee <[email protected]> * Update AttemptOpenStep.kt Signed-off-by: Annie Lee <[email protected]> * Add close action test Signed-off-by: Annie Lee <[email protected]> * Add open action related tests Signed-off-by: Annie Lee <[email protected]> * Add open action test round trip Signed-off-by: Annie Lee <[email protected]> * Fix open action xcontent test Signed-off-by: Annie Lee <[email protected]> * Modify XContentTests for better comparison Signed-off-by: Annie Lee <[email protected]> * Update XContentTests.kt Signed-off-by: Annie Lee <[email protected]> Implements RolloverAction with new interface, fixes default action retry commit (opensearch-project#231) * Implements rollover action with new interface, fixes default action retry Signed-off-by: Clay Downs <[email protected]> Support ReplicaCountAction using new interface (opensearch-project#233) Signed-off-by: Annie Lee <[email protected]> Refactors rollup action and enables multi step actions (opensearch-project#235) Signed-off-by: Robert Downs <[email protected]> Refactors Notification action with new interface (opensearch-project#238) * Refactors notification action with new interface Signed-off-by: Robert Downs <[email protected]> Upgrades detekt version, fixes flaky tests (opensearch-project#254) * Upgrades detekt version to 1.17.1 (opensearch-project#252) * Adds detekt ignores to not-yet-refactored files * Fixes flaky rollup/transform explain IT (opensearch-project#247) Signed-off-by: Robert Downs <[email protected]> Support force merge action using new interface (opensearch-project#256) * Support force merge action Signed-off-by: Annie Lee <[email protected]> Refactors Snapshot action to use new interface (opensearch-project#253) * Refactors snapshot action to use new interface Signed-off-by: Clay Downs <[email protected]> Support index priority action using new interface (opensearch-project#257) Signed-off-by: Annie Lee <[email protected]> Support Allocation action using new interface (opensearch-project#246) * Support Allocation action using new interface Signed-off-by: Annie Lee <[email protected]> * Pass in required parameter Signed-off-by: Annie Lee <[email protected]> * Update AttemptAllocationStep.kt Adding correct const Signed-off-by: Annie Lee <[email protected]> * Update AttemptAllocationStep.kt Typo in message Signed-off-by: Annie Lee <[email protected]> * Debug tests Signed-off-by: Annie Lee <[email protected]> * Update XContentTests.kt Signed-off-by: Annie Lee <[email protected]> * Revert "Debug tests" This reverts commit d7123bd. Signed-off-by: Annie Lee <[email protected]> * Update IndexPolicyRequestTests.kt Signed-off-by: Annie Lee <[email protected]> * Support force merge action using new interface (opensearch-project#256) * Support force merge action Signed-off-by: Annie Lee <[email protected]> * Update AllocationActionIT.kt Signed-off-by: Annie Lee <[email protected]> * Revert "Update IndexPolicyRequestTests.kt" This reverts commit bd34e2e. Signed-off-by: Annie Lee <[email protected]> * Add debug log Signed-off-by: Annie Lee <[email protected]> * Remove debug log and change order of parameters Signed-off-by: Annie Lee <[email protected]> * Update after comments Fix order of include exclude parameter in parser Add check to tests Remove "Config" in message Signed-off-by: Annie Lee <[email protected]> Merging changes from main branch (opensearch-project#259) Signed-off-by: Ravi Thaluru <[email protected]> merge with main (opensearch-project#270) Signed-off-by: Ravi Thaluru <[email protected]> Adds custom action parsing (opensearch-project#273) * Adds custom action parsing logic Signed-off-by: Robert Downs <[email protected]> Refactor coordinator to support create and delete index events when different index types exist on cluster (opensearch-project#272) * Refactor coordinator to support different index type create and delete events and sweep Signed-off-by: Ravi Thaluru <[email protected]> introducing custom uuid setting in SPI (opensearch-project#278) * introducing custom uuid setting in SPI Signed-off-by: Ravi Thaluru <[email protected]> Refactors the managed index runner to work with extensions (opensearch-project#262) * Adds index creation date Signed-off-by: Robert Downs <[email protected]> Adds NewClusterEventListeners and refactors Transition to work with custom actions Signed-off-by: Robert Downs <[email protected]> Marks blocked actions list as deprecated Signed-off-by: Clay Downs <[email protected]> Asserts the deprecation warning after adding to allow list in test Signed-off-by: Robert Downs <[email protected]> Removes allow_list test Signed-off-by: Robert Downs <[email protected]> * Fix additional rebase issues Signed-off-by: Robert Downs <[email protected]> * Fixes failing tests Signed-off-by: Robert Downs <[email protected]> * changes based on comments Signed-off-by: Robert Downs <[email protected]> * Adds additional comments Signed-off-by: Clay Downs <[email protected]> Makes rest APIs use new metadata service (opensearch-project#245) * Makes rest API use new metadata service Signed-off-by: Robert Downs <[email protected]> Adds missed flags (opensearch-project#286) Signed-off-by: Clay Downs <[email protected]> Ports over show-applied-policies logic (opensearch-project#287) Signed-off-by: Clay Downs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
NA
Description of changes:
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.